pull request #2547
manual merge due to modification of unrelated files according to GitHub's
files view
Co-authored-by: host12prog <hungnguyen.481335@gmail.com>
This method/variables are for notify sample is changed/altered/added/removed. can be called together with updateSampleTex for sample update.
multipcm: Fix possible desync with instrument and sample parameter
opl4: Split sample table render and sample data render, Add notifySampleChange for refresh sample parameters
E4x is the correct ID, not E3x, for MOD and XM.
Additionally, updated the coding style for MOD to be more consistent with the
pre-existing code, namely by not using hex for the effect IDs being checked.
Fine print:
- Enabling and disabling panning envelopes take up two effect columns instead of
one due to the macro being split into left and right sides.
Fine print:
- OpenMPT hacks are not implemented here for MOD and XM for random waveform
- Retrigger/Continuous setting is not handled for MOD, XM and S3M
-- For S3M, I can't confirm if the setting even existed:
I'm pretty sure it got cut out of Impulse Tracker.
- Your waveform may sound different here than in the original player
If tremolo and panbrello waveforms are implemented in Furnace, then their
corresponding conversions can be implemented. For now, though, they can't make
the cut since there is no corresponding effect to change those waveforms from
the default setting.
Partially revert previous commit
Add notifyInsAddition in dispatch for instrument addition
Refresh sample memory when instrument type changed
Fix naming for consistency
Also, this commit fixes a some possible issue in MultiPCM on openMSX core.
Chip ID: Already determined
for refresh sample memory when loop/end pointer and instrument parameter changed. Also, this PR has minor code style fixes and add warning in MultiPCM sample map usage.
Add QSound ADPCM sample warning:
Because QSound ADPCM has twice long max sample length but start/end addresses are byte aligned, doesn't have loop and pitch (fixed to output rate / 3).
