otomatalabs/furnace
8
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

remove unused globalPitch variable

Browse source
This commit is contained in:
tildearrow 2025-10-22 14:25:03 -05:00
parent 4d56e72278
commit d2f7c49aa4
3 changed files with 2 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/engine/engine.cpp
View file

@ -1520,14 +1520,13 @@ String DivEngine::getPlaybackDebugInfo() {
"totalCmds: %d\n" "totalCmds: %d\n"
"lastCmds: %d\n" "lastCmds: %d\n"
"cmdsPerSecond: %d\n" "cmdsPerSecond: %d\n"
"globalPitch: %d\n"
"extValue: %d\n" "extValue: %d\n"
"tempoAccum: %d\n" "tempoAccum: %d\n"
"totalProcessed: %d\n" "totalProcessed: %d\n"
"bufferPos: %d\n", "bufferPos: %d\n",
curOrder,prevOrder,curRow,prevRow,ticks,subticks,totalLoops,lastLoopPos,nextSpeed,divider,cycles,clockDrift, curOrder,prevOrder,curRow,prevRow,ticks,subticks,totalLoops,lastLoopPos,nextSpeed,divider,cycles,clockDrift,
midiClockCycles,midiClockDrift,midiTimeCycles,midiTimeDrift,changeOrd,changePos,totalSeconds,totalTicks, midiClockCycles,midiClockDrift,midiTimeCycles,midiTimeDrift,changeOrd,changePos,totalSeconds,totalTicks,
totalTicksR,curMidiClock,curMidiTime,totalCmds,lastCmds,cmdsPerSecond,globalPitch, totalTicksR,curMidiClock,curMidiTime,totalCmds,lastCmds,cmdsPerSecond,
(int)extValue,(int)tempoAccum,(int)totalProcessed,(int)bufferPos (int)extValue,(int)tempoAccum,(int)totalProcessed,(int)bufferPos
); );
} }
@ -2174,7 +2173,6 @@ void DivEngine::reset() {
elapsedBeats=0; elapsedBeats=0;
nextSpeed=speeds.val[0]; nextSpeed=speeds.val[0];
divider=curSubSong->hz; divider=curSubSong->hz;
globalPitch=0;
for (int i=0; i<song.systemLen; i++) { for (int i=0; i<song.systemLen; i++) {
disCont[i].dispatch->reset(); disCont[i].dispatch->reset();
disCont[i].clear(); disCont[i].clear();

3
src/engine/engine.h
View file

@ -485,7 +485,7 @@ class DivEngine {
int midiTimeCycles; int midiTimeCycles;
double midiTimeDrift; double midiTimeDrift;
int stepPlay; int stepPlay;
int changeOrd, changePos, totalSeconds, totalTicks, totalTicksR, curMidiClock, curMidiTime, totalCmds, lastCmds, cmdsPerSecond, globalPitch; int changeOrd, changePos, totalSeconds, totalTicks, totalTicksR, curMidiClock, curMidiTime, totalCmds, lastCmds, cmdsPerSecond;
double totalTicksOff; double totalTicksOff;
int curMidiTimePiece, curMidiTimeCode; int curMidiTimePiece, curMidiTimeCode;
unsigned char extValue, pendingMetroTick; unsigned char extValue, pendingMetroTick;
@ -1475,7 +1475,6 @@ class DivEngine {
totalCmds(0), totalCmds(0),
lastCmds(0), lastCmds(0),
cmdsPerSecond(0), cmdsPerSecond(0),
globalPitch(0),
totalTicksOff(0.0), totalTicksOff(0.0),
curMidiTimePiece(0), curMidiTimePiece(0),
curMidiTimeCode(0), curMidiTimeCode(0),

6
src/engine/playback.cpp
View file

@ -1465,12 +1465,6 @@ void DivEngine::processRow(int i, bool afterDelay) {
extValuePresent=true; extValuePresent=true;
dispatchCmd(DivCommand(DIV_CMD_EXTERNAL,i,effectVal)); dispatchCmd(DivCommand(DIV_CMD_EXTERNAL,i,effectVal));
break; break;
case 0xef: // global pitch
// this is a legacy effect that only works in partial pitch linearity.
// it adds to the global pitch but results in crazy frequency errors if this is too high.
// it is hidden from the GUI and will be removed once partial pitch linearity is obliterated from Furnace.
globalPitch+=(signed char)(effectVal-0x80);
break;
case 0xf0: // set Hz by tempo case 0xf0: // set Hz by tempo
// the resulting tick rate is effectVal*2/5 // the resulting tick rate is effectVal*2/5
// 125 BPM = 50Hz; 150 BPM = 60Hz... // 125 BPM = 50Hz; 150 BPM = 60Hz...