From d2f7c49aa409fe55acdd4c9b6cedbcfe4da1e9e3 Mon Sep 17 00:00:00 2001
From: tildearrow <me@tildearrow.org>
Date: Wed, 22 Oct 2025 14:25:03 -0500
Subject: [PATCH] remove unused globalPitch variable

---
 src/engine/engine.cpp   | 4 +---
 src/engine/engine.h     | 3 +--
 src/engine/playback.cpp | 6 ------
 3 files changed, 2 insertions(+), 11 deletions(-)

diff --git a/src/engine/engine.cpp b/src/engine/engine.cpp
index 6959e038f..13b9f7efa 100644
--- a/src/engine/engine.cpp
+++ b/src/engine/engine.cpp
@@ -1520,14 +1520,13 @@ String DivEngine::getPlaybackDebugInfo() {
     "totalCmds: %d\n"
     "lastCmds: %d\n"
     "cmdsPerSecond: %d\n"
-    "globalPitch: %d\n"
     "extValue: %d\n"
     "tempoAccum: %d\n"
     "totalProcessed: %d\n"
     "bufferPos: %d\n",
     curOrder,prevOrder,curRow,prevRow,ticks,subticks,totalLoops,lastLoopPos,nextSpeed,divider,cycles,clockDrift,
     midiClockCycles,midiClockDrift,midiTimeCycles,midiTimeDrift,changeOrd,changePos,totalSeconds,totalTicks,
-    totalTicksR,curMidiClock,curMidiTime,totalCmds,lastCmds,cmdsPerSecond,globalPitch,
+    totalTicksR,curMidiClock,curMidiTime,totalCmds,lastCmds,cmdsPerSecond,
     (int)extValue,(int)tempoAccum,(int)totalProcessed,(int)bufferPos
   );
 }
@@ -2174,7 +2173,6 @@ void DivEngine::reset() {
   elapsedBeats=0;
   nextSpeed=speeds.val[0];
   divider=curSubSong->hz;
-  globalPitch=0;
   for (int i=0; i<song.systemLen; i++) {
     disCont[i].dispatch->reset();
     disCont[i].clear();
diff --git a/src/engine/engine.h b/src/engine/engine.h
index db1d52c92..07a4d99a5 100644
--- a/src/engine/engine.h
+++ b/src/engine/engine.h
@@ -485,7 +485,7 @@ class DivEngine {
   int midiTimeCycles;
   double midiTimeDrift;
   int stepPlay;
-  int changeOrd, changePos, totalSeconds, totalTicks, totalTicksR, curMidiClock, curMidiTime, totalCmds, lastCmds, cmdsPerSecond, globalPitch;
+  int changeOrd, changePos, totalSeconds, totalTicks, totalTicksR, curMidiClock, curMidiTime, totalCmds, lastCmds, cmdsPerSecond;
   double totalTicksOff;
   int curMidiTimePiece, curMidiTimeCode;
   unsigned char extValue, pendingMetroTick;
@@ -1475,7 +1475,6 @@ class DivEngine {
       totalCmds(0),
       lastCmds(0),
       cmdsPerSecond(0),
-      globalPitch(0),
       totalTicksOff(0.0),
       curMidiTimePiece(0),
       curMidiTimeCode(0),
diff --git a/src/engine/playback.cpp b/src/engine/playback.cpp
index 09b8c1a79..7158f79bd 100644
--- a/src/engine/playback.cpp
+++ b/src/engine/playback.cpp
@@ -1465,12 +1465,6 @@ void DivEngine::processRow(int i, bool afterDelay) {
         extValuePresent=true;
         dispatchCmd(DivCommand(DIV_CMD_EXTERNAL,i,effectVal));
         break;
-      case 0xef: // global pitch
-        // this is a legacy effect that only works in partial pitch linearity.
-        // it adds to the global pitch but results in crazy frequency errors if this is too high.
-        // it is hidden from the GUI and will be removed once partial pitch linearity is obliterated from Furnace.
-        globalPitch+=(signed char)(effectVal-0x80);
-        break;
       case 0xf0: // set Hz by tempo
         // the resulting tick rate is effectVal*2/5
         // 125 BPM = 50Hz; 150 BPM = 60Hz...