From f9889ce92095c5d3416745b4af3925adbfe21f4e Mon Sep 17 00:00:00 2001 From: Eknous-P Date: Thu, 24 Jul 2025 09:32:27 +0400 Subject: [PATCH] mark modified when changing compat flags or ins type --- src/gui/compatFlags.cpp | 113 ++++++++++++++++++++++------------------ src/gui/insEdit.cpp | 1 + 2 files changed, 64 insertions(+), 50 deletions(-) diff --git a/src/gui/compatFlags.cpp b/src/gui/compatFlags.cpp index 1cefe7b79..39bdfd338 100644 --- a/src/gui/compatFlags.cpp +++ b/src/gui/compatFlags.cpp @@ -32,182 +32,182 @@ void FurnaceGUI::drawCompatFlags() { ImGui::TextWrapped(_("these flags are designed to provide better DefleMask/older Furnace compatibility.\nit is recommended to disable most of these unless you rely on specific quirks.")); if (ImGui::BeginTabBar("settingsTab")) { if (ImGui::BeginTabItem(_("DefleMask"))) { - ImGui::Checkbox(_("Limit slide range"),&e->song.limitSlides); + if (ImGui::Checkbox(_("Limit slide range"),&e->song.limitSlides)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("when enabled, slides are limited to a compatible range.\nmay cause problems with slides in negative octaves.")); } - InvCheckbox(_("Compatible noise layout on NES and PC Engine"),&e->song.properNoiseLayout); + if (InvCheckbox(_("Compatible noise layout on NES and PC Engine"),&e->song.properNoiseLayout)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("use a rather unusual compatible noise frequency layout.\nremoves some noise frequencies on PC Engine.")); } - ImGui::Checkbox(_("Game Boy instrument duty is wave volume"),&e->song.waveDutyIsVol); + if (ImGui::Checkbox(_("Game Boy instrument duty is wave volume"),&e->song.waveDutyIsVol)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("if enabled, an instrument with duty macro in the wave channel will be mapped to wavetable volume.")); } - ImGui::Checkbox(_("Restart macro on portamento"),&e->song.resetMacroOnPorta); + if (ImGui::Checkbox(_("Restart macro on portamento"),&e->song.resetMacroOnPorta)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("when enabled, a portamento effect will reset the channel's macro if used in combination with a note.")); } - ImGui::Checkbox(_("Legacy volume slides"),&e->song.legacyVolumeSlides); + if (ImGui::Checkbox(_("Legacy volume slides"),&e->song.legacyVolumeSlides)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("simulate glitchy volume slide behavior by silently overflowing the volume when the slide goes below 0.")); } - ImGui::Checkbox(_("Compatible arpeggio"),&e->song.compatibleArpeggio); + if (ImGui::Checkbox(_("Compatible arpeggio"),&e->song.compatibleArpeggio)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("delay arpeggio by one tick on every new note.")); } - ImGui::Checkbox(_("Disable DAC when sample ends"),&e->song.brokenDACMode); + if (ImGui::Checkbox(_("Disable DAC when sample ends"),&e->song.brokenDACMode)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("when enabled, the DAC in YM2612 will be disabled if there isn't any sample playing.")); } - ImGui::Checkbox(_("Broken speed alternation"),&e->song.brokenSpeedSel); + if (ImGui::Checkbox(_("Broken speed alternation"),&e->song.brokenSpeedSel)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("determines next speed based on whether the row is odd/even instead of alternating between speeds.")); } - ImGui::Checkbox(_("Ignore duplicate slide effects"),&e->song.ignoreDuplicateSlides); + if (ImGui::Checkbox(_("Ignore duplicate slide effects"),&e->song.ignoreDuplicateSlides)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("if this is on, only the first slide of a row in a channel will be considered.")); } - ImGui::Checkbox(_("Ignore 0Dxx on the last order"),&e->song.ignoreJumpAtEnd); + if (ImGui::Checkbox(_("Ignore 0Dxx on the last order"),&e->song.ignoreJumpAtEnd)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("if this is on, a jump to next row effect will not take place when it is on the last order of a song.")); } - ImGui::Checkbox(_("Buggy portamento after pitch slide"),&e->song.buggyPortaAfterSlide); + if (ImGui::Checkbox(_("Buggy portamento after pitch slide"),&e->song.buggyPortaAfterSlide)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("simulates a bug in where portamento does not work after sliding.")); } - ImGui::Checkbox(_("FM pitch slide octave boundary odd behavior"),&e->song.fbPortaPause); + if (ImGui::Checkbox(_("FM pitch slide octave boundary odd behavior"),&e->song.fbPortaPause)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("if this is on, a pitch slide that crosses the octave boundary will stop for one tick and then continue from the nearest octave boundary.\nfor .dmf compatibility.")); } - InvCheckbox(_("Don't apply Game Boy envelope on note-less instrument change"),&e->song.gbInsAffectsEnvelope); + if (InvCheckbox(_("Don't apply Game Boy envelope on note-less instrument change"),&e->song.gbInsAffectsEnvelope)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("if this is on, an instrument change will not affect the envelope.")); } - ImGui::Checkbox(_("Ignore DAC mode change outside of intended channel in ExtCh mode"),&e->song.ignoreDACModeOutsideIntendedChannel); + if (ImGui::Checkbox(_("Ignore DAC mode change outside of intended channel in ExtCh mode"),&e->song.ignoreDACModeOutsideIntendedChannel)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("if this is on, 17xx has no effect on the operator channels in YM2612.")); } - ImGui::Checkbox(_("E1xy/E2xy also take priority over slide stops"),&e->song.e1e2AlsoTakePriority); + if (ImGui::Checkbox(_("E1xy/E2xy also take priority over slide stops"),&e->song.e1e2AlsoTakePriority)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("does this make any sense by now?")); } - ImGui::Checkbox(_("E1xy/E2xy stop when repeating the same note"),&e->song.e1e2StopOnSameNote); + if (ImGui::Checkbox(_("E1xy/E2xy stop when repeating the same note"),&e->song.e1e2StopOnSameNote)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("ugh, if only this wasn't a thing...")); } - ImGui::Checkbox(_("SN76489 duty macro always resets phase"),&e->song.snDutyReset); + if (ImGui::Checkbox(_("SN76489 duty macro always resets phase"),&e->song.snDutyReset)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("when enabled, duty macro will always reset phase, even if its value hasn't changed.")); } - InvCheckbox(_("Broken volume scaling strategy"),&e->song.newVolumeScaling); + if (InvCheckbox(_("Broken volume scaling strategy"),&e->song.newVolumeScaling)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("when enabled:\n- log scaling: multiply\n- linear scaling: subtract\nwhen disabled:\n- log scaling: subtract\n- linear scaling: multiply")); } - InvCheckbox(_("Don't persist volume macro after it finishes"),&e->song.volMacroLinger); + if (InvCheckbox(_("Don't persist volume macro after it finishes"),&e->song.volMacroLinger)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("when enabled, a value in the volume column that happens after the volume macro is done will disregard the macro.")); } - ImGui::Checkbox(_("Broken output volume on instrument change"),&e->song.brokenOutVol); + if (ImGui::Checkbox(_("Broken output volume on instrument change"),&e->song.brokenOutVol)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("if enabled, no checks for the presence of a volume macro will be made.\nthis will cause the last macro value to linger unless a value in the volume column is present.")); } - ImGui::Checkbox(_("Broken output volume - Episode 2 (PLEASE KEEP ME DISABLED)"),&e->song.brokenOutVol2); + if (ImGui::Checkbox(_("Broken output volume - Episode 2 (PLEASE KEEP ME DISABLED)"),&e->song.brokenOutVol2)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("these compatibility flags are getting SO damn ridiculous and out of control.\nas you may have guessed, this one exists due to yet ANOTHER DefleMask-specific behavior.\nplease keep this off at all costs, because I will not support it when ROM export comes.\noh, and don't start an argument out of it. Furnace isn't a DefleMask replacement, and no,\nI am not trying to make it look like one with all these flags.\n\noh, and what about the other flags that don't have to do with DefleMask?\nthose are for .mod import, future FamiTracker import and personal taste!\n\nend of rant")); } - ImGui::Checkbox(_("Treat SN76489 periods under 8 as 1"),&e->song.snNoLowPeriods); + if (ImGui::Checkbox(_("Treat SN76489 periods under 8 as 1"),&e->song.snNoLowPeriods)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("when enabled, any SN period under 8 will be written as 1 instead.\nthis replicates DefleMask behavior, but reduces available period range.")); } ImGui::EndTabItem(); } if (ImGui::BeginTabItem(_("Old Furnace"))) { - ImGui::Checkbox(_("Arpeggio inhibits non-porta slides"),&e->song.arpNonPorta); + if (ImGui::Checkbox(_("Arpeggio inhibits non-porta slides"),&e->song.arpNonPorta)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.5.5")); } - ImGui::Checkbox(_("Wack FM algorithm macro"),&e->song.algMacroBehavior); + if (ImGui::Checkbox(_("Wack FM algorithm macro"),&e->song.algMacroBehavior)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.5.5")); } - ImGui::Checkbox(_("Broken shortcut slides (E1xy/E2xy)"),&e->song.brokenShortcutSlides); + if (ImGui::Checkbox(_("Broken shortcut slides (E1xy/E2xy)"),&e->song.brokenShortcutSlides)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.5.7")); } - ImGui::Checkbox(_("Stop portamento on note off"),&e->song.stopPortaOnNoteOff); + if (ImGui::Checkbox(_("Stop portamento on note off"),&e->song.stopPortaOnNoteOff)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6pre1")); } - InvCheckbox(_("Don't allow instrument change during slides"),&e->song.newInsTriggersInPorta); + if (InvCheckbox(_("Don't allow instrument change during slides"),&e->song.newInsTriggersInPorta)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6pre1")); } - InvCheckbox(_("Don't reset note to base on arpeggio stop"),&e->song.arp0Reset); + if (InvCheckbox(_("Don't reset note to base on arpeggio stop"),&e->song.arp0Reset)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6pre1")); } - InvCheckbox(_("ExtCh channel status is not shared among operators"),&e->song.sharedExtStat); + if (InvCheckbox(_("ExtCh channel status is not shared among operators"),&e->song.sharedExtStat)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6pre1")); } - InvCheckbox(_("Disable new SegaPCM features (macros and better panning)"),&e->song.newSegaPCM); + if (InvCheckbox(_("Disable new SegaPCM features (macros and better panning)"),&e->song.newSegaPCM)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6pre1")); } - ImGui::Checkbox(_("Old FM octave boundary behavior"),&e->song.oldOctaveBoundary); + if (ImGui::Checkbox(_("Old FM octave boundary behavior"),&e->song.oldOctaveBoundary)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6pre1")); } - ImGui::Checkbox(_("Disable OPN2 DAC volume control"),&e->song.noOPN2Vol); + if (ImGui::Checkbox(_("Disable OPN2 DAC volume control"),&e->song.noOPN2Vol)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6pre1")); } - ImGui::Checkbox(_("Broken initial position of portamento after arpeggio"),&e->song.brokenPortaArp); + if (ImGui::Checkbox(_("Broken initial position of portamento after arpeggio"),&e->song.brokenPortaArp)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6pre1.5")); } - ImGui::Checkbox(_("Disable new sample features"),&e->song.disableSampleMacro); + if (ImGui::Checkbox(_("Disable new sample features"),&e->song.disableSampleMacro)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6pre2")); } - ImGui::Checkbox(_("Old arpeggio macro + pitch slide strategy"),&e->song.oldArpStrategy); + if (ImGui::Checkbox(_("Old arpeggio macro + pitch slide strategy"),&e->song.oldArpStrategy)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6pre2")); } - ImGui::Checkbox(_("Broken portamento during legato"),&e->song.brokenPortaLegato); + if (ImGui::Checkbox(_("Broken portamento during legato"),&e->song.brokenPortaLegato)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6pre4")); } - ImGui::Checkbox(_("Broken macros in some FM chips after note off"),&e->song.brokenFMOff); + if (ImGui::Checkbox(_("Broken macros in some FM chips after note off"),&e->song.brokenFMOff)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6pre5")); } - ImGui::Checkbox(_("Pre-note does not take effects into consideration"),&e->song.preNoteNoEffect); + if (ImGui::Checkbox(_("Pre-note does not take effects into consideration"),&e->song.preNoteNoEffect)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6pre9")); } - ImGui::Checkbox(_("Disable new NES DPCM features"),&e->song.oldDPCM); + if (ImGui::Checkbox(_("Disable new NES DPCM features"),&e->song.oldDPCM)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6.1")); } - ImGui::Checkbox(_("Legacy technical ALWAYS_SET_VOLUME behavior"),&e->song.oldAlwaysSetVolume); + if (ImGui::Checkbox(_("Legacy technical ALWAYS_SET_VOLUME behavior"),&e->song.oldAlwaysSetVolume)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6.1\nthis flag will be removed if I find out that none of the songs break after disabling it.")); } - ImGui::Checkbox(_("Old sample offset effect"),&e->song.oldSampleOffset); + if (ImGui::Checkbox(_("Old sample offset effect"),&e->song.oldSampleOffset)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("behavior changed in 0.6.3")); } ImGui::EndTabItem(); } if (ImGui::BeginTabItem(_(".mod import"))) { - ImGui::Checkbox(_("Don't slide on the first tick of a row"),&e->song.noSlidesOnFirstTick); + if (ImGui::Checkbox(_("Don't slide on the first tick of a row"),&e->song.noSlidesOnFirstTick)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("simulates ProTracker's behavior of not applying volume/pitch slides on the first tick of a row.")); } - ImGui::Checkbox(_("Reset arpeggio position on row change"),&e->song.rowResetsArpPos); + if (ImGui::Checkbox(_("Reset arpeggio position on row change"),&e->song.rowResetsArpPos)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("simulates ProTracker's behavior of arpeggio being bound to the current tick of a row.")); } @@ -218,6 +218,7 @@ void FurnaceGUI::drawCompatFlags() { ImGui::Indent(); if (ImGui::RadioButton(_("None"),e->song.linearPitch==0)) { e->song.linearPitch=0; + MARK_MODIFIED } if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("like ProTracker/FamiTracker")); @@ -226,6 +227,7 @@ void FurnaceGUI::drawCompatFlags() { pushWarningColor(true); if (ImGui::RadioButton(_("Partial (only 04xy/E5xx)"),e->song.linearPitch==1)) { e->song.linearPitch=1; + MARK_MODIFIED } if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("like DefleMask\n\nthis pitch linearity mode is deprecated due to:\n- excessive complexity\n- lack of possible optimization\n\nit is recommended to change it now because I will remove this option in the future!")); @@ -234,6 +236,7 @@ void FurnaceGUI::drawCompatFlags() { } if (ImGui::RadioButton(_("Full"),e->song.linearPitch==2)) { e->song.linearPitch=2; + MARK_MODIFIED } if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("like Impulse Tracker")); @@ -246,6 +249,7 @@ void FurnaceGUI::drawCompatFlags() { if (ImGui::InputScalar(_("Pitch slide speed multiplier"),ImGuiDataType_U8,&e->song.pitchSlideSpeed,&_ONE,&_ONE)) { if (e->song.pitchSlideSpeed<1) e->song.pitchSlideSpeed=1; if (e->song.pitchSlideSpeed>64) e->song.pitchSlideSpeed=64; + MARK_MODIFIED } } @@ -253,18 +257,21 @@ void FurnaceGUI::drawCompatFlags() { ImGui::Indent(); if (ImGui::RadioButton(_("Reset channels"),e->song.loopModality==0)) { e->song.loopModality=0; + MARK_MODIFIED } if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("select to reset channels on loop. may trigger a voltage click on every loop!")); } if (ImGui::RadioButton(_("Soft reset channels"),e->song.loopModality==1)) { e->song.loopModality=1; + MARK_MODIFIED } if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("select to turn channels off on loop.")); } if (ImGui::RadioButton(_("Do nothing"),e->song.loopModality==2)) { e->song.loopModality=2; + MARK_MODIFIED } if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("select to not reset channels on loop.")); @@ -275,18 +282,21 @@ void FurnaceGUI::drawCompatFlags() { ImGui::Indent(); if (ImGui::RadioButton(_("Strict"),e->song.delayBehavior==0)) { e->song.delayBehavior=0; + MARK_MODIFIED } if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("only when time is less than speed (like DefleMask/ProTracker)")); } if (ImGui::RadioButton(_("Strict (old)"),e->song.delayBehavior==1)) { e->song.delayBehavior=1; + MARK_MODIFIED } if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("only when time is less than or equal to speed (original buggy behavior)")); } if (ImGui::RadioButton(_("Lax"),e->song.delayBehavior==2)) { e->song.delayBehavior=2; + MARK_MODIFIED } if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("no checks")); @@ -297,18 +307,21 @@ void FurnaceGUI::drawCompatFlags() { ImGui::Indent(); if (ImGui::RadioButton(_("Normal"),e->song.jumpTreatment==0)) { e->song.jumpTreatment=0; + MARK_MODIFIED } if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("accept 0B+0D to jump to a specific row of an order")); } if (ImGui::RadioButton(_("Old Furnace"),e->song.jumpTreatment==1)) { e->song.jumpTreatment=1; + MARK_MODIFIED } if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("only accept the first jump effect")); } if (ImGui::RadioButton(_("DefleMask"),e->song.jumpTreatment==2)) { e->song.jumpTreatment=2; + MARK_MODIFIED } if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("only accept 0Dxx")); @@ -317,34 +330,34 @@ void FurnaceGUI::drawCompatFlags() { ImGui::EndTabItem(); } if (ImGui::BeginTabItem(_("Other"))) { - ImGui::Checkbox(_("Auto-insert one tick gap between notes"),&e->song.oneTickCut); + if (ImGui::Checkbox(_("Auto-insert one tick gap between notes"),&e->song.oneTickCut)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("when enabled, a one-tick note cut will be inserted between non-legato/non-portamento notes.\nthis simulates the behavior of some Amiga/SNES music engines.\n\nineffective on C64.")); } ImGui::Separator(); - InvCheckbox(_("Don't reset slides after note off"),&e->song.noteOffResetsSlides); + if (InvCheckbox(_("Don't reset slides after note off"),&e->song.noteOffResetsSlides)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("when enabled, note off will not reset the channel's slide effect.")); } - InvCheckbox(_("Don't reset portamento after reaching target"),&e->song.targetResetsSlides); + if (InvCheckbox(_("Don't reset portamento after reaching target"),&e->song.targetResetsSlides)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("when enabled, the slide effect will not be disabled after it reaches its target.")); } - ImGui::Checkbox(_("Continuous vibrato"),&e->song.continuousVibrato); + if (ImGui::Checkbox(_("Continuous vibrato"),&e->song.continuousVibrato)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("when enabled, vibrato phase/position will not be reset on a new note.")); } - InvCheckbox(_("Pitch macro is not linear"),&e->song.pitchMacroIsLinear); + if (InvCheckbox(_("Pitch macro is not linear"),&e->song.pitchMacroIsLinear)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("when enabled, the pitch macro of an instrument is in frequency/period space.")); } - ImGui::Checkbox(_("Reset arpeggio effect position on new note"),&e->song.resetArpPhaseOnNewNote); + if (ImGui::Checkbox(_("Reset arpeggio effect position on new note"),&e->song.resetArpPhaseOnNewNote)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("when enabled, arpeggio effect (00xy) position is reset on a new note.")); } - ImGui::Checkbox(_("Volume scaling rounds up"),&e->song.ceilVolumeScaling); + if (ImGui::Checkbox(_("Volume scaling rounds up"),&e->song.ceilVolumeScaling)) MARK_MODIFIED if (ImGui::IsItemHovered()) { ImGui::SetTooltip(_("when enabled, volume macros round up when applied\nthis prevents volume scaling from causing vol=0, which is silent on some chips\n\nineffective on logarithmic channels")); } diff --git a/src/gui/insEdit.cpp b/src/gui/insEdit.cpp index 29a537ffe..c928bcdfd 100644 --- a/src/gui/insEdit.cpp +++ b/src/gui/insEdit.cpp @@ -6745,6 +6745,7 @@ void FurnaceGUI::drawInsEdit() { for (DivInstrumentType i: insTypeList) { if (ImGui::Selectable(insTypes[i][0],insType==i)) { ins->type=i; + MARK_MODIFIED // reset macro zoom memset(ins->temp.vZoom,-1,sizeof(ins->temp.vZoom));