otomatalabs/furnace
8
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

dev191 - kind of remove DIV_ALWAYS_SET_VOLUME

Browse source 
it's useless crap I put during the Defle compat days
it serves nearly no purpose nowadays

also why is it a command?
This commit is contained in:
tildearrow 2024-01-16 23:54:32 -05:00
parent 95aff38cb2
commit f8187b9a5f
87 changed files with 105 additions and 207 deletions
Download patch file Download diff file Expand all files Collapse all files

7
src/engine/playback.cpp
View file

@ -246,9 +246,6 @@ const char* cmdName[]={
"ESFM_OUTLVL",
"ESFM_MODIN",
"ESFM_ENV_DELAY",
"ALWAYS_SET_VOLUME",
};
static_assert((sizeof(cmdName)/sizeof(void*))==DIV_CMD_MAX,"update cmdName!");
@ -273,8 +270,6 @@ int DivEngine::dispatchCmd(DivCommand c) {
if (!skipping) {
switch (c.cmd) {
// strip away hinted/useless commands
case DIV_ALWAYS_SET_VOLUME:
break;
case DIV_CMD_GET_VOLUME:
break;
case DIV_CMD_VOLUME:
@ -621,7 +616,7 @@ void DivEngine::processRow(int i, bool afterDelay) {
// volume
if (pat->data[whatRow][3]!=-1) {
if (dispatchCmd(DivCommand(DIV_ALWAYS_SET_VOLUME,i)) || (MIN(chan[i].volMax,chan[i].volume)>>8)!=pat->data[whatRow][3]) {
if (!song.oldAlwaysSetVolume || disCont[dispatchOfChan[i]].dispatch->getLegacyAlwaysSetVolume() || (MIN(chan[i].volMax,chan[i].volume)>>8)!=pat->data[whatRow][3]) {
if (pat->data[whatRow][0]==0 && pat->data[whatRow][1]==0) {
chan[i].midiAftertouch=true;
}