From e9cf03f8c99df091f3b5c1cc843b36d352709ffc Mon Sep 17 00:00:00 2001 From: tildearrow Date: Wed, 6 Sep 2023 18:53:03 -0500 Subject: [PATCH] GUI: add warnings for ADPCM-B looped samples issue #1451 --- src/gui/sampleEdit.cpp | 18 +++++++++++++++++- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/src/gui/sampleEdit.cpp b/src/gui/sampleEdit.cpp index 05377169b..3d17bec78 100644 --- a/src/gui/sampleEdit.cpp +++ b/src/gui/sampleEdit.cpp @@ -262,7 +262,10 @@ void FurnaceGUI::drawSampleEdit() { case DIV_SYSTEM_YM2608_CSM: if (sample->loop) { if (sample->loopStart!=0 || sample->loopEnd!=(int)(sample->samples)) { - SAMPLE_WARN(warnLoopPos,"YM2608: loop point ignored on ADPCM-B (may only loop entire sample)"); + SAMPLE_WARN(warnLoopPos,"YM2608: loop point ignored on ADPCM (may only loop entire sample)"); + } + if (sample->samples&511) { + SAMPLE_WARN(warnLength,"YM2608: sample length will be padded to multiple of 512"); } } break; @@ -276,6 +279,9 @@ void FurnaceGUI::drawSampleEdit() { if (sample->loopStart!=0 || sample->loopEnd!=(int)(sample->samples)) { SAMPLE_WARN(warnLoopPos,"YM2610: loop point ignored on ADPCM-B (may only loop entire sample)"); } + if (sample->samples&511) { + SAMPLE_WARN(warnLength,"YM2610: sample length will be padded to multiple of 512"); + } } if (sample->samples>2097152) { SAMPLE_WARN(warnLength,"YM2610: maximum ADPCM-A sample length is 2097152"); @@ -284,6 +290,16 @@ void FurnaceGUI::drawSampleEdit() { EXACT_RATE("YM2610 (ADPCM-A)",dispatch->chipClock/432); } break; + case DIV_SYSTEM_Y8950: + if (sample->loop) { + if (sample->loopStart!=0 || sample->loopEnd!=(int)(sample->samples)) { + SAMPLE_WARN(warnLoopPos,"Y8950: loop point ignored on ADPCM (may only loop entire sample)"); + } + if (sample->samples&511) { + SAMPLE_WARN(warnLength,"Y8950: sample length will be padded to multiple of 512"); + } + } + break; case DIV_SYSTEM_AMIGA: if (sample->loop) { if (sample->loopStart&1 || sample->loopEnd&1) {