otomatalabs/furnace
7
0
Fork 0
Code Issues Pull requests Actions Packages Projects Releases Wiki Activity

MSM5232: work around possible chip quirk

Browse source 
when changing control, it seemingly retriggers all channels
issue #1433
This commit is contained in:
tildearrow 2023-08-28 16:36:26 -05:00
parent f07ad0044b
commit decd2fde0f
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/engine/platform/msm5232.cpp
View file

@ -20,9 +20,9 @@
#define _USE_MATH_DEFINES #define _USE_MATH_DEFINES
#include "msm5232.h" #include "msm5232.h"
#include "../engine.h" #include "../engine.h"
#include "../../ta-log.h"
#include <math.h> #include <math.h>
//#define rWrite(a,v) pendingWrites[a]=v;
#define rWrite(a,v) if (!skipRegisterWrites) {writes.push(QueuedWrite(a,v)); if (dumpWrites) {addWrite(a,v);} } #define rWrite(a,v) if (!skipRegisterWrites) {writes.push(QueuedWrite(a,v)); if (dumpWrites) {addWrite(a,v);} }
#define NOTE_LINEAR(x) ((x)<<7) #define NOTE_LINEAR(x) ((x)<<7)
@ -49,6 +49,7 @@ void DivPlatformMSM5232::acquire(short** buf, size_t len) {
for (size_t h=0; h<len; h++) { for (size_t h=0; h<len; h++) {
while (!writes.empty()) { while (!writes.empty()) {
QueuedWrite w=writes.front(); QueuedWrite w=writes.front();
logV("%.2x = %.2x\n",w.addr,w.val);
msm->write(w.addr,w.val); msm->write(w.addr,w.val);
regPool[w.addr&0x0f]=w.val; regPool[w.addr&0x0f]=w.val;
writes.pop(); writes.pop();
@ -125,6 +126,10 @@ void DivPlatformMSM5232::tick(bool sysTick) {
for (int i=0; i<2; i++) { for (int i=0; i<2; i++) {
if (updateGroup[i]) { if (updateGroup[i]) {
rWrite(12+i,groupControl[i]); rWrite(12+i,groupControl[i]);
// do not retrigger inactive channels
for (int j=i<<2; j<(i+1)<<2; j++) {
if (!chan[j].active) rWrite(j,0);
}
updateGroup[i]=false; updateGroup[i]=false;
} }
if (updateGroupAR[i]) { if (updateGroupAR[i]) {