From 99e59278ad34a1aac14c9182fc41479820128f5e Mon Sep 17 00:00:00 2001
From: tildearrow <tildearrow@protonmail.com>
Date: Wed, 9 Jun 2021 01:08:42 -0500
Subject: [PATCH] PCE: kind of implement LFO

---
 src/engine/dispatch.h         |  3 +++
 src/engine/platform/dummy.cpp | 16 +++++++++++++++-
 src/engine/platform/dummy.h   |  7 ++++---
 src/engine/platform/pce.cpp   |  6 ++++++
 src/engine/playback.cpp       |  9 +++++++++
 5 files changed, 37 insertions(+), 4 deletions(-)

diff --git a/src/engine/dispatch.h b/src/engine/dispatch.h
index 28609f8ae..0ddb30469 100644
--- a/src/engine/dispatch.h
+++ b/src/engine/dispatch.h
@@ -37,6 +37,9 @@ enum DivDispatchCmds {
   DIV_CMD_GB_SWEEP_TIME,
   DIV_CMD_GB_SWEEP_DIR,
 
+  DIV_CMD_PCE_LFO_MODE,
+  DIV_CMD_PCE_LFO_SPEED,
+
   DIV_ALWAYS_SET_VOLUME,
 
   DIV_CMD_MAX
diff --git a/src/engine/platform/dummy.cpp b/src/engine/platform/dummy.cpp
index fa773cb51..ef30bae3e 100644
--- a/src/engine/platform/dummy.cpp
+++ b/src/engine/platform/dummy.cpp
@@ -18,13 +18,19 @@ void DivPlatformDummy::tick() {
   for (unsigned char i=0; i<chans; i++) {
     chan[i].amp--;
     if (chan[i].amp<0) chan[i].amp=0;
+
+    if (chan[i].freqChanged) {
+      chan[i].freqChanged=false;
+      chan[i].freq=(chan[i].baseFreq*(ONE_SEMITONE+chan[i].pitch))/ONE_SEMITONE;
+    }
   }
 }
 
 int DivPlatformDummy::dispatch(DivCommand c) {
   switch (c.cmd) {
     case DIV_CMD_NOTE_ON:
-      chan[c.chan].freq=16.4f*pow(2.0f,((float)c.value/12.0f));
+      chan[c.chan].baseFreq=16.4f*pow(2.0f,((float)c.value/12.0f));
+      chan[c.chan].freqChanged=true;
       chan[c.chan].active=true;
       chan[c.chan].amp=64;
       break;
@@ -38,6 +44,14 @@ int DivPlatformDummy::dispatch(DivCommand c) {
     case DIV_CMD_GET_VOLUME:
       return chan[c.chan].vol;
       break;
+    case DIV_CMD_PITCH:
+      chan[c.chan].pitch=c.value;
+      chan[c.chan].freqChanged=true;
+      break;
+    case DIV_CMD_LEGATO:
+      chan[c.chan].baseFreq=16.4f*pow(2.0f,((float)c.value/12.0f));
+      chan[c.chan].freqChanged=true;
+      break;
     case DIV_CMD_GET_VOLMAX:
       return 15;
       break;
diff --git a/src/engine/platform/dummy.h b/src/engine/platform/dummy.h
index 595c1d8ce..333389d90 100644
--- a/src/engine/platform/dummy.h
+++ b/src/engine/platform/dummy.h
@@ -4,12 +4,13 @@
 // used when a DivDispatch for a system is not found.
 class DivPlatformDummy: public DivDispatch {
   struct Channel {
-    unsigned short freq;
+    unsigned short freq, baseFreq;
+    short pitch;
     unsigned short pos;
-    bool active;
+    bool active, freqChanged;
     unsigned char vol;
     signed char amp;
-    Channel(): freq(0), pos(0), active(false), vol(0), amp(64) {}
+    Channel(): freq(0), baseFreq(0), pitch(0), pos(0), active(false), freqChanged(false), vol(0), amp(64) {}
   };
   Channel chan[17];
   unsigned char chans;
diff --git a/src/engine/platform/pce.cpp b/src/engine/platform/pce.cpp
index d357e33be..57db7b5d0 100644
--- a/src/engine/platform/pce.cpp
+++ b/src/engine/platform/pce.cpp
@@ -186,6 +186,12 @@ int DivPlatformPCE::dispatch(DivCommand c) {
       updateWave(c.chan);
       chan[c.chan].keyOn=true;
       break;
+    case DIV_CMD_PCE_LFO_MODE:
+      rWrite(0x09,c.value);
+      break;
+    case DIV_CMD_PCE_LFO_SPEED:
+      rWrite(0x08,c.value);
+      break;
     case DIV_CMD_NOTE_PORTA: {
       int destFreq=round(FREQ_BASE/pow(2.0f,((float)c.value2/12.0f)));
       bool return2=false;
diff --git a/src/engine/playback.cpp b/src/engine/playback.cpp
index bc58400d2..d632ff23f 100644
--- a/src/engine/playback.cpp
+++ b/src/engine/playback.cpp
@@ -45,6 +45,9 @@ const char* cmdName[DIV_CMD_MAX]={
   "GB_SWEEP_TIME",
   "GB_SWEEP_DIR",
 
+  "PCE_LFO_MODE",
+  "PCE_LFO_SPEED",
+
   "ALWAYS_SET_VOLUME"
 };
 
@@ -117,6 +120,12 @@ bool DivEngine::perSystemEffect(int ch, unsigned char effect, unsigned char effe
         case 0x11: // noise mode
           dispatchCmd(DivCommand(DIV_CMD_STD_NOISE_MODE,ch,effectVal));
           break;
+        case 0x12: // LFO mode
+          dispatchCmd(DivCommand(DIV_CMD_PCE_LFO_MODE,ch,effectVal));
+          break;
+        case 0x13: // LFO speed
+          dispatchCmd(DivCommand(DIV_CMD_PCE_LFO_SPEED,ch,effectVal));
+          break;
         case 0x17: // PCM enable
           dispatchCmd(DivCommand(DIV_CMD_SAMPLE_MODE,ch,(effectVal>0)));
           break;