From 65a6a55d3ec5aaf6373a9c2d00803261465bde3e Mon Sep 17 00:00:00 2001
From: bbbradsmith <bbbradsmith@users.noreply.github.com>
Date: Fri, 13 Dec 2024 05:42:30 -0500
Subject: [PATCH] avoid stricmp entirely, just use the lowerCase boilerplate
 found in many other places in the code

---
 src/main.cpp | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/main.cpp b/src/main.cpp
index c1c85270f..1cb5e58e8 100644
--- a/src/main.cpp
+++ b/src/main.cpp
@@ -19,7 +19,6 @@
 
 #include <stdio.h>
 #include <stdint.h>
-#include <string.h>
 #include "pch.h"
 #ifdef HAVE_SDL2
 #include "SDL_events.h"
@@ -921,13 +920,17 @@ int main(int argc, char** argv) {
       e.setConsoleMode(true);
       // select ROM target type
       DivROMExportOptions romTarget = DIV_ROM_ABSTRACT;
+      String lowerCase=romOutName;
+      for (char& i: lowerCase) {
+        if (i>='A' && i<='Z') i+='a'-'A';
+      }
       for (int i=0; i<DIV_ROM_MAX; i++) {
         DivROMExportOptions opt = (DivROMExportOptions)i;
         if (e.isROMExportViable(opt)) {
           const DivROMExportDef* newDef=e.getROMExportDef((DivROMExportOptions)i);
           if (newDef->fileExt &&
-              romOutName.length()>=strlen(newDef->fileExt) &&
-              !stricmp(newDef->fileExt,romOutName.c_str()+(romOutName.length()-strlen(newDef->fileExt)))) {
+              lowerCase.length()>=strlen(newDef->fileExt) &&
+              lowerCase.substr(lowerCase.length()-strlen(newDef->fileExt))==newDef->fileExt) {
             romTarget = opt;
             break; // extension matched, stop searching
           }