From 5a2d4662aa699d8bf14404acec78ff09c17503c1 Mon Sep 17 00:00:00 2001 From: tildearrow Date: Sun, 9 Mar 2025 01:27:59 -0500 Subject: [PATCH] NDS: get rid of core quality --- src/engine/dispatchContainer.cpp | 5 ----- src/engine/platform/nds.cpp | 26 -------------------------- src/engine/platform/nds.h | 2 -- src/gui/gui.h | 4 ---- src/gui/settings.cpp | 8 -------- 5 files changed, 45 deletions(-) diff --git a/src/engine/dispatchContainer.cpp b/src/engine/dispatchContainer.cpp index 684984aba..d9d6d3d5e 100644 --- a/src/engine/dispatchContainer.cpp +++ b/src/engine/dispatchContainer.cpp @@ -775,11 +775,6 @@ void DivDispatchContainer::init(DivSystem sys, DivEngine* eng, int chanCount, do break; case DIV_SYSTEM_NDS: dispatch=new DivPlatformNDS; - if (isRender) { - ((DivPlatformNDS*)dispatch)->setCoreQuality(eng->getConfInt("ndsQualityRender",3)); - } else { - ((DivPlatformNDS*)dispatch)->setCoreQuality(eng->getConfInt("ndsQuality",3)); - } break; case DIV_SYSTEM_5E01: dispatch=new DivPlatformNES; diff --git a/src/engine/platform/nds.cpp b/src/engine/platform/nds.cpp index 7a0d821d8..efe499114 100644 --- a/src/engine/platform/nds.cpp +++ b/src/engine/platform/nds.cpp @@ -579,32 +579,6 @@ void DivPlatformNDS::setFlags(const DivConfig& flags) { memCompo.capacity=(isDSi?16777216:4194304); } -void DivPlatformNDS::setCoreQuality(unsigned char q) { - switch (q) { - case 0: - coreQuality=1024; - break; - case 1: - coreQuality=512; - break; - case 2: - coreQuality=256; - break; - case 3: - coreQuality=128; - break; - case 4: - coreQuality=32; - break; - case 5: - coreQuality=8; - break; - default: - coreQuality=128; - break; - } -} - int DivPlatformNDS::init(DivEngine* p, int channels, int sugRate, const DivConfig& flags) { parent=p; dumpWrites=false; diff --git a/src/engine/platform/nds.h b/src/engine/platform/nds.h index 98c5f6bec..b673e9283 100644 --- a/src/engine/platform/nds.h +++ b/src/engine/platform/nds.h @@ -55,7 +55,6 @@ class DivPlatformNDS: public DivDispatch, public nds_sound_intf { unsigned char* sampleMem; size_t sampleMemLen; - int coreQuality; nds_sound_t nds; DivMemoryComposition memCompo; unsigned char regPool[288]; @@ -95,7 +94,6 @@ class DivPlatformNDS: public DivDispatch, public nds_sound_intf { virtual const DivMemoryComposition* getMemCompo(int index) override; virtual void renderSamples(int chipID) override; virtual void setFlags(const DivConfig& flags) override; - void setCoreQuality(unsigned char q); virtual int init(DivEngine* parent, int channels, int sugRate, const DivConfig& flags) override; virtual void quit() override; DivPlatformNDS(): diff --git a/src/gui/gui.h b/src/gui/gui.h index ece471084..e488c91e1 100644 --- a/src/gui/gui.h +++ b/src/gui/gui.h @@ -1798,7 +1798,6 @@ class FurnaceGUI { int bubsysQuality; int dsidQuality; int gbQuality; - int ndsQuality; int pnQuality; int saaQuality; int smQuality; @@ -1821,7 +1820,6 @@ class FurnaceGUI { int bubsysQualityRender; int dsidQualityRender; int gbQualityRender; - int ndsQualityRender; int pnQualityRender; int saaQualityRender; int smQualityRender; @@ -2055,7 +2053,6 @@ class FurnaceGUI { bubsysQuality(3), dsidQuality(3), gbQuality(3), - ndsQuality(3), pnQuality(3), saaQuality(3), smQuality(3), @@ -2078,7 +2075,6 @@ class FurnaceGUI { bubsysQualityRender(3), dsidQualityRender(3), gbQualityRender(3), - ndsQualityRender(3), pnQualityRender(3), saaQualityRender(3), smQualityRender(3), diff --git a/src/gui/settings.cpp b/src/gui/settings.cpp index a4efbfd14..d42a6d1a1 100644 --- a/src/gui/settings.cpp +++ b/src/gui/settings.cpp @@ -2122,7 +2122,6 @@ void FurnaceGUI::drawSettings() { CORE_QUALITY("Bubble System WSG",bubsysQuality,bubsysQualityRender); CORE_QUALITY("Game Boy",gbQuality,gbQualityRender); - CORE_QUALITY("Nintendo DS",ndsQuality,ndsQualityRender); CORE_QUALITY("PowerNoise",pnQuality,pnQualityRender); CORE_QUALITY("SAA1099",saaQuality,saaQualityRender); CORE_QUALITY("SID (dSID)",dsidQuality,dsidQualityRender); @@ -5130,7 +5129,6 @@ void FurnaceGUI::readConfig(DivConfig& conf, FurnaceGUISettingGroups groups) { settings.bubsysQuality=conf.getInt("bubsysQuality",3); settings.dsidQuality=conf.getInt("dsidQuality",3); settings.gbQuality=conf.getInt("gbQuality",3); - settings.ndsQuality=conf.getInt("ndsQuality",3); settings.pnQuality=conf.getInt("pnQuality",3); settings.saaQuality=conf.getInt("saaQuality",3); settings.smQuality=conf.getInt("smQuality",3); @@ -5155,7 +5153,6 @@ void FurnaceGUI::readConfig(DivConfig& conf, FurnaceGUISettingGroups groups) { settings.bubsysQualityRender=conf.getInt("bubsysQualityRender",3); settings.dsidQualityRender=conf.getInt("dsidQualityRender",3); settings.gbQualityRender=conf.getInt("gbQualityRender",3); - settings.ndsQualityRender=conf.getInt("ndsQualityRender",3); settings.pnQualityRender=conf.getInt("pnQualityRender",3); settings.saaQualityRender=conf.getInt("saaQualityRender",3); settings.smQualityRender=conf.getInt("smQualityRender",3); @@ -5196,7 +5193,6 @@ void FurnaceGUI::readConfig(DivConfig& conf, FurnaceGUISettingGroups groups) { clampSetting(settings.bubsysQuality,0,5); clampSetting(settings.dsidQuality,0,5); clampSetting(settings.gbQuality,0,5); - clampSetting(settings.ndsQuality,0,5); clampSetting(settings.pnQuality,0,5); clampSetting(settings.saaQuality,0,5); clampSetting(settings.smQuality,0,5); @@ -5219,7 +5215,6 @@ void FurnaceGUI::readConfig(DivConfig& conf, FurnaceGUISettingGroups groups) { clampSetting(settings.bubsysQualityRender,0,5); clampSetting(settings.dsidQualityRender,0,5); clampSetting(settings.gbQualityRender,0,5); - clampSetting(settings.ndsQualityRender,0,5); clampSetting(settings.pnQualityRender,0,5); clampSetting(settings.saaQualityRender,0,5); clampSetting(settings.smQualityRender,0,5); @@ -5716,7 +5711,6 @@ void FurnaceGUI::writeConfig(DivConfig& conf, FurnaceGUISettingGroups groups) { conf.set("bubsysQuality",settings.bubsysQuality); conf.set("dsidQuality",settings.dsidQuality); conf.set("gbQuality",settings.gbQuality); - conf.set("ndsQuality",settings.ndsQuality); conf.set("pnQuality",settings.pnQuality); conf.set("saaQuality",settings.saaQuality); conf.set("smQuality",settings.smQuality); @@ -5741,7 +5735,6 @@ void FurnaceGUI::writeConfig(DivConfig& conf, FurnaceGUISettingGroups groups) { conf.set("bubsysQualityRender",settings.bubsysQualityRender); conf.set("dsidQualityRender",settings.dsidQualityRender); conf.set("gbQualityRender",settings.gbQualityRender); - conf.set("ndsQualityRender",settings.ndsQualityRender); conf.set("pnQualityRender",settings.pnQualityRender); conf.set("saaQualityRender",settings.saaQualityRender); conf.set("smQualityRender",settings.smQualityRender); @@ -5800,7 +5793,6 @@ void FurnaceGUI::commitSettings() { settings.bubsysQuality!=e->getConfInt("bubsysQuality",3) || settings.dsidQuality!=e->getConfInt("dsidQuality",3) || settings.gbQuality!=e->getConfInt("gbQuality",3) || - settings.ndsQuality!=e->getConfInt("ndsQuality",3) || settings.pnQuality!=e->getConfInt("pnQuality",3) || settings.saaQuality!=e->getConfInt("saaQuality",3) || settings.smQuality!=e->getConfInt("smQuality",3) ||