From 3df67fb1b3c1a614842aaeb69b71dcc79ff9dad3 Mon Sep 17 00:00:00 2001 From: KungFuFurby Date: Tue, 9 Sep 2025 18:36:02 -0400 Subject: [PATCH] Add some commentary for special series of effects in S3M, XM and IT --- src/engine/fileOps/it.cpp | 6 +++--- src/engine/fileOps/s3m.cpp | 6 +++--- src/engine/fileOps/xm.cpp | 8 ++++---- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/engine/fileOps/it.cpp b/src/engine/fileOps/it.cpp index 0975ed698..facbecaf9 100644 --- a/src/engine/fileOps/it.cpp +++ b/src/engine/fileOps/it.cpp @@ -1516,15 +1516,15 @@ bool DivEngine::loadIT(unsigned char* file, size_t len) { break; case 'S': // special... switch (effectVal[chan]>>4) { - case 0x8: + case 0x8: // panning p->data[readRow][effectCol[chan]++]=0x80; p->data[readRow][effectCol[chan]++]=(effectVal[chan]&15)<<4; break; - case 0xc: + case 0xc: // note cut p->data[readRow][effectCol[chan]++]=0xec; p->data[readRow][effectCol[chan]++]=effectVal[chan]&15; break; - case 0xd: + case 0xd: // note delay p->data[readRow][effectCol[chan]++]=0xed; p->data[readRow][effectCol[chan]++]=effectVal[chan]&15; break; diff --git a/src/engine/fileOps/s3m.cpp b/src/engine/fileOps/s3m.cpp index f7d4ea22b..aacfc4fdf 100644 --- a/src/engine/fileOps/s3m.cpp +++ b/src/engine/fileOps/s3m.cpp @@ -1101,15 +1101,15 @@ bool DivEngine::loadS3M(unsigned char* file, size_t len) { break; case 'S': // special... switch (effectVal>>4) { - case 0x8: + case 0x8: // panning p->data[readRow][effectCol[chan]++]=0x80; p->data[readRow][effectCol[chan]++]=(effectVal&15)<<4; break; - case 0xc: + case 0xc: // note cut p->data[readRow][effectCol[chan]++]=0xec; p->data[readRow][effectCol[chan]++]=effectVal&15; break; - case 0xd: + case 0xd: // note delay p->data[readRow][effectCol[chan]++]=0xed; p->data[readRow][effectCol[chan]++]=effectVal&15; break; diff --git a/src/engine/fileOps/xm.cpp b/src/engine/fileOps/xm.cpp index 6627d0e73..f78973ee8 100644 --- a/src/engine/fileOps/xm.cpp +++ b/src/engine/fileOps/xm.cpp @@ -1147,11 +1147,11 @@ bool DivEngine::loadXM(unsigned char* file, size_t len) { case 0xe: // special... // TODO: implement the rest switch (effectVal>>4) { - case 0x5: + case 0x5: // fine tune p->data[j][effectCol[k]++]=0xe5; p->data[j][effectCol[k]++]=(effectVal&15)<<4; break; - case 0x9: + case 0x9: // retrigger p->data[j][effectCol[k]++]=0x0c; p->data[j][effectCol[k]++]=(effectVal&15); break; @@ -1171,11 +1171,11 @@ bool DivEngine::loadXM(unsigned char* file, size_t len) { } volSliding[k]=true; break; - case 0xc: + case 0xc: // note cut p->data[j][effectCol[k]++]=0xdc; p->data[j][effectCol[k]++]=MAX(1,effectVal&15); break; - case 0xd: + case 0xd: // note delay p->data[j][effectCol[k]++]=0xed; p->data[j][effectCol[k]++]=MAX(1,effectVal&15); break;